[Development] V8's location

Thiago Macieira thiago.macieira at intel.com
Mon Oct 24 14:15:38 CEST 2011

On Monday, 24 de October de 2011 10.11.00, Simon Hausmann wrote:
> > Can we move V8 out of qtbase and into a top-level module? I've done that
> > mistake above several times. The fact that V8 is inside qtbase means I
> > cannot do a git commit -a, despite the submodule ignore command.
> > 
> > Also, can we move it to Gitorious and enable Gerrit for it? I have a patch
> > to make it compile with ICC and I'd rather not have to create a github
> > account just for this.
> Isn't the right solution then to get your patch either upstream or into the
> Qt copy?

Yes and no. Yes, I should get my fixes into the Qt copy (at least). But it's 
not a full solution since very often I have pending changes or in-progress 
development that I committed.

To put it bluntly: git submodules should not be used in an active repository.

> I'm not sure if putting v8 into gerrit helps much, because things like
> rebasing are much harder with Gerrit. In a strange sense we want to make it
> difficult to modify our fork of V8 :)

You can give push-to-branch rights in Gerrit, which allows rebasing.

> That said, does your employer allow you to contribute the patch upstream?

To Qt, it's in progress and should happen soon. To V8, definitely not for me.

If the repository is not moved to Gerrit, which is fine, I'll probably just 
publish my changes in Gitorious and expect V8's maintainer to merge them on 
their own.

But please move the submodule to qt5.git.

Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20111024/47877dbc/attachment.sig>
-------------- next part --------------
Intel Sweden AB
Registered Office: Knarrarnasgatan 15, 164 40 Kista, Stockholm, Sweden
Registration Number: 556189-6027

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the Development mailing list