[Development] The final mile

[Stephen Kelly]

On Sunday, December 02, 2012 12:27:18 Hausmann Simon wrote:
> Hi,
> 
> I can try to add some clarifications.
> 
> It is our intention to make it so that when you write
> 
>     QT += webkitwidgets
> 

Did you also consider how you might have to change how the cmake files are 
generated?

Do you now generate both lib/cmake/QtWebKit/QtWebKitConfig.cmake and 
lib/cmake/QtWebKitWidgets/QtWebKitWidgetsConfig.cmake ?

Do the directories include/QtWebKitWidgets and include/QtWebKit exist and 
contain corresponding headers? Eg does include/QtWebKitWidgets/QWebView and 
include/QtWebKit/QWebElement exist, for example?

Do libraries like lib/libQt5WebKit.* and lib/libQt5WebKitWidgets.* exist? 

If not then you may be generating bogus broken cmake files for QtWebKit now.

Please add a unit test to the webkit test system for the cmake stuff. See for 
example tests/auto/cmake in the qtscript repo for how that's done in the Qt CI 
system. For webkit, the cmake.pro can probably just be the same, and the 
CMakeLists.txt would look something like this:


 cmake_minimum_required(VERSION 2.8)

 project(qmake_cmake_files)

 enable_testing()

 find_package(Qt5Core REQUIRED)

 include("${_Qt5CTestMacros}")

 set(Qt5_MODULE_TEST_DEPENDS Widgets)

 test_module_includes(
   WebKit QWebView
   WebKitWidgets QWebElement
 )

Thanks,

-- 
Stephen Kelly <stephen.kelly at kdab.com> | Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
** Qt Developer Conference: http://qtconference.kdab.com/ **
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20121202/575b618c/attachment.sig>