[Development] [Qt-creator] gerrit-speak
Martin Smith
Martin.Smith at digia.com
Fri Dec 14 11:27:58 CET 2012
On Dec 14, 2012, at 10:40 AM, Sune Vuorela wrote:
> On 2012-12-13, Jenssen Tim <Tim.Jenssen at digia.com> wrote:
>>> "I would prefer that you didn't submit this"
>>>
>>> reads to my brain much like "go f*k yourself" without the raw words.
>>>
>>> I get all the idea of the automating thing and all, and that machines have no
>>> emotion, but, if I don't miss something obvious (this happens to me though...)
>>> and if that message is configurable, how about
>>>
>>> "This requires more work"
>>>
>>> instead?
>>
>> +1
>> Yes this describes more the workflow how I use that with my colleges.
>
> +1
>
> I also had that kind of feeling in the beginning until I discovered it
> was the default message.
>
> /Sune
>
+1
my problem with "I would prefer that you didn't submit this" is that -1 is often used without including an explanation of what is wrong and how it should be fixed.
I like "This requires more work" better, but I think it will still be abused. Maybe it should be something incomplete, like this:
"Before you submit this..."
And then it should require text min the comments area. The text should, of course, give the rationale for the -1 and the suggestion for fixing the problem.
martin
More information about the Development
mailing list