[Development] [Qt-creator] gerrit-speak

[Joseph Crowell]

On 14/12/2012 8:27 PM, Martin Smith wrote:
> +1
>
> my problem with "I would prefer that you didn't submit this" is that -1 is often used without including an explanation of what is wrong and how it should be fixed.
>
> I like "This requires more work" better, but I think it will still be abused. Maybe it should be something incomplete, like this:
>
> "Before you submit this..."
>
> And then it should require text min the comments area. The text should, of course, give the rationale for the -1 and the suggestion for fixing the problem.
>
> martin

This makes far too much sense to be accepted. int vote = 0; while ( vote 
 > -1) { vote + 1; }

> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development