[Development] API review for a new QDnsResolver class

[Jeremy Lainé]

On 01/05/2012 01:03 AM, Craig.Scott at csiro.au wrote:
>> Some notes about the implementation:
>>
>> - the actual lookup code is run in a thread, managed by a global threadpool (QHostInfo-style)
> What happens if the client/user is also employing their own thread pool? Does your implementation simply set some arbitrary number of threads it will use and assume the system will take care of scheduling threads fairly (probably the only safe option)? Are you making use of QThread::idealThreadCount(), in which case it probably won't give the behaviour expected with the client/user also employing their own separate thread pool? Just wondering if using a thread pool here is really buying you anything over simply using QThread directly (but I guess if you are trying to manage supporting a large number of DNS queries then it makes sense to limit how many can be processed at once via a thread pool).
>

I followed QHostInfo's pattern exactly here: I set a fixed maximum number of threads (5) 
on the pool.

Jeremy