[Development] fixing name of QNetworkAccessManager::createRequest
Thiago Macieira
thiago.macieira at intel.com
Fri Jan 13 14:08:00 CET 2012
On Friday, 13 de January de 2012 14.10.09, Robin Burchell wrote:
> 2012/1/13 Thiago Macieira <thiago.macieira at intel.com>:
> > So, changing the name of this function is:
> >
> > - of little practical benefit
> > - not 100% automatable without a code scanner
> > - dangerous, as it creates silent bugs
>
> what about the slightly more garden-variety approach of deprecating
> the old one and introducing a new method?
It's a virtual, which means both methods must be virtual and they will be
there until 6.0. I frankly think it's worse to have *both* createRequest and
createReply.
I'll let the proponents of this change figure out how to have both virtuals,
both overridable and do the right thing.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120113/09cfacf9/attachment.sig>
More information about the Development
mailing list