[Development] fixing name of QNetworkAccessManager::createRequest

lars.knoll at nokia.com lars.knoll at nokia.com
Sun Jan 15 17:30:11 CET 2012


On 1/15/12 5:08 PM, "ext Richard Moore" <rich at kde.org> wrote:

>On Sun, Jan 15, 2012 at 2:25 PM, Peter Kümmel <syntheticpp at gmx.net> wrote:
>> But to think first about what "createRequest" really does is a good
>>idea:
>> It not only creates a request, it also sends it, so why not rename it to
>> 'doRequest' or something similar which is different to 'createReply'
>> which is as misleading as 'createRequest'.
>>
>> A new name would stop the compiler and there will be no silent bugs.
>> And replacing a simple function name isn't that hard, so there is no
>> need for a 'migration path' via deprecated functions.
>
>There would still be silent errors for people who have reimplemented
>the createRequest method (it's virtual). I think this was covered
>earlier in this thread.

Yes, let's close it. All the maintainers and Approvers knowing QtNetwork
seem to agree (and I actually do as well) to keep the name.

Cheers,
Lars




More information about the Development mailing list