[Development] Help reviewing my own changes to QSharedPointer

Thiago Macieira thiago.macieira at intel.com
Wed Jun 6 18:53:44 CEST 2012


Cf. thread: Maintainer "TrustMes"
http://lists.qt-project.org/pipermail/development/2012-April/002930.html
http://comments.gmane.org/gmane.comp.lib.qt.devel/2953

I need help again reviewing my own changes. Since I am the maintainer of the 
module that the changes are going to, there's no one else to call upon. I 
asked Lars and he said he can't safely review them. I'm asking the community 
here to help out.

The first two changes are extremely important and must be done before 5.0:

https://codereview.qt-project.org/26974 - Remove "delete value"
https://codereview.qt-project.org/26975 - Remove virtuals from the private

The next few changes are cleanups:
https://codereview.qt-project.org/26977 - Merge two private classes
https://codereview.qt-project.org/26978 - Merge the private to the public
https://codereview.qt-project.org/26979 - Use the copy & swap trick

Then there are some optimisations:
https://codereview.qt-project.org/26980 - Optimise the constructor
https://codereview.qt-project.org/26981 - Optimise deletion

One new feature (we should leave for 5.1):
https://codereview.qt-project.org/26982 - Add create() with variadic arguments 
and perfect forwarding

And one unit test:
https://codereview.qt-project.org/27043 - lambda as custom deleter

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120606/df02e0c7/attachment.sig>


More information about the Development mailing list