[Development] Help reviewing my own changes to QSharedPointer

[lars.knoll at nokia.com]

Can't remember that you asked me. I can certainly review them if you don't have anyone else. I'll do so later tonight.


Cheers,

Lars


On 06.06.12 18:54 ext Thiago Macieira wrote:

Cf. thread: Maintainer "TrustMes"
http://lists.qt-project.org/pipermail/development/2012-April/002930.html
http://lists.qt-project.org/pipermail/development/2012-April/002930.html

I need help again reviewing my own changes. Since I am the maintainer of the
module that the changes are going to, there's no one else to call upon. I
asked Lars and he said he can't safely review them. I'm asking the community
here to help out.

The first two changes are extremely important and must be done before 5.0:

http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Remove "delete value"
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Remove virtuals from the private

The next few changes are cleanups:
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Merge two private classes
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Merge the private to the public
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Use the copy & swap trick

Then there are some optimisations:
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Optimise the constructor
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Optimise deletion

One new feature (we should leave for 5.1):
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Add create() with variadic arguments
and perfect forwarding

And one unit test:
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - lambda as custom deleter

--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120606/366e1a5e/attachment.html>