[Development] QtV8: Order of arguments on Runtime::kResolvePossiblyDirectEval inconsistent

Kent Hansen kent.hansen at nokia.com
Wed May 9 08:09:31 CEST 2012

Hi Holger,

Den 08. mai 2012 23:04, skrev ext Holger Hans Peter Freyther:
> Hi,
> I am looking into why QtV8 stopped working for MIPS (the obvious candidate is
> that there is lithium support now). While doing this I noted that in
> FullCodeGenerator::EmitResolvePossiblyDirectEval the following is not consistent:
> ARM:
> 1.) language_mode
> 2.) is_qml_mode
> 3.) start_position
> ia32, mips, amd64:
> 1.) language_mode
> 2.) start_position
> 3.) is_qml_mode
> the ResolvePossiblyDirectEval is shared across all implementations. So is the
> ARM code wrong?

Well spotted. Looks like a regression that was introduced in the QML 
mode patch when we updated to V8 3.10.1.
I'll make sure we have sufficient test coverage so this won't regress again.

Best regards,

More information about the Development mailing list