[Development] Proposing reversal of the Math3D qreal->float change

Thiago Macieira thiago.macieira at intel.com
Tue Sep 11 14:34:08 CEST 2012


51d40d7e9bdfc63c5109aef5b732aa2ba10f985a changed the types of the Math3D 
classes from qreal to float. That's a major source- and behaviour-incompatible 
change, done after the beta, with no mention in the changelog or discussion on 
this mailing list (unless it's an old discussion and it's only now made it 
through).

Note that half of the issues we've found so far are due to test failures after 
the change in precision. That means we're introducing subtle and hard-to-find 
behaviour incompatibilities.

I propose we revert it.

Build logs with failures relating to that change:

 - QtMultimedia: still broken
http://testresults.qt-
project.org/ci/QtMultimedia_master_Integration/build_00521/linux-g%2B%2B_no-
widgets_Ubuntu_12.04_x64/log.txt.gz

 - Qt3D: finally fixed, after 8 attempts
http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00289/linux-g%2B%2B_shadow-
build_Ubuntu_11.10_x86/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00287/linux-
g%2B%2B-32_Ubuntu_10.04_x86/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00285/linux-
g%2B%2B-32_Ubuntu_10.04_x86/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00284/linux-g%2B%2B_developer-
build_qtnamespace_qtlibinfix_Ubuntu_11.10_x64/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00283/linux-
g%2B%2B-32_Ubuntu_10.04_x86/log.txt.gz

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120911/432e4a1b/attachment.sig>


More information about the Development mailing list