[Development] Proposing reversal of the Math3D qreal->float change

marco.bubke at nokia.com marco.bubke at nokia.com
Tue Sep 11 14:46:56 CEST 2012


But than we would be not have the same behaviour, if qreal is float or double. Actually I changed every code in the qml designer explicitly to double or float. It would be really nice, if the Qt classes would be has  a float and a double implementation. From my perspective qreal is breaking the cross plattform promise!

regards, Marco
________________________________________
From: development-bounces+marco.bubke=nokia.com at qt-project.org [development-bounces+marco.bubke=nokia.com at qt-project.org] on behalf of ext Thiago Macieira [thiago.macieira at intel.com]
Sent: Tuesday, September 11, 2012 2:34 PM
To: development at qt-project.org
Subject: [Development] Proposing reversal of the Math3D qreal->float change

51d40d7e9bdfc63c5109aef5b732aa2ba10f985a changed the types of the Math3D
classes from qreal to float. That's a major source- and behaviour-incompatible
change, done after the beta, with no mention in the changelog or discussion on
this mailing list (unless it's an old discussion and it's only now made it
through).

Note that half of the issues we've found so far are due to test failures after
the change in precision. That means we're introducing subtle and hard-to-find
behaviour incompatibilities.

I propose we revert it.

Build logs with failures relating to that change:

 - QtMultimedia: still broken
http://testresults.qt-
project.org/ci/QtMultimedia_master_Integration/build_00521/linux-g%2B%2B_no-
widgets_Ubuntu_12.04_x64/log.txt.gz

 - Qt3D: finally fixed, after 8 attempts
http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00289/linux-g%2B%2B_shadow-
build_Ubuntu_11.10_x86/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00287/linux-
g%2B%2B-32_Ubuntu_10.04_x86/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00285/linux-
g%2B%2B-32_Ubuntu_10.04_x86/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00284/linux-g%2B%2B_developer-
build_qtnamespace_qtlibinfix_Ubuntu_11.10_x64/log.txt.gz

http://testresults.qt-
project.org/ci/Qt3D_master_Integration/build_00283/linux-
g%2B%2B-32_Ubuntu_10.04_x86/log.txt.gz

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden



More information about the Development mailing list