[Development] Qt5 Cmake Scripts: wrong include path or Unnecessary?

[Stephen Kelly]

On Saturday, September 15, 2012 16:19:49 Loaden wrote:
> > It's probably the same. "default" is either a copy or a symlink to the
> > mkspec
> > Qt was compiled with.
> 
> On Windows, "default" not a copy neither symlink. It only include an
> qmake.conf

Indeed. This is why you can't include qplatformdefs.h on windows if you use 
cmake with Qt 5. 

Rather than having the symlink in the include directories, we should have the 
mkspec path, but we can't do that until 

https://bugreports.qt-project.org/browse/QTBUG-26869

is fixed.

On Saturday, September 15, 2012 10:36:20 Thiago Macieira wrote:
> > Does we really need qplatformdefs.h for compile Qt-based application?
> > I guess it only used to compile Qt self.
> 
> Fortunately, it's only included from private headers, so regular
> applications  will not see it.

* It's qplatformdefs.h, not qplatformdefs_p.h
* The include directory for it is part of QT += core, not core-private

If we want qplatformdefs to be a private header, then we'd have to change both 
of those.

I know that's not exactly what you said, but actually I think it's a good 
idea.

It is used in kdelibs in a few places.

Thanks,

-- 
Stephen Kelly <stephen.kelly at kdab.com> | Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
** Qt Developer Conference: http://qtconference.kdab.com/ **
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120916/943fb731/attachment.sig>