[Development] Qt5 Cmake Scripts: wrong include path or Unnecessary?

[Thiago Macieira]

On domingo, 16 de setembro de 2012 10.33.11, Stephen Kelly wrote:
> On Saturday, September 15, 2012 10:36:20 Thiago Macieira wrote:
> > > Does we really need qplatformdefs.h for compile Qt-based application?
> > > I guess it only used to compile Qt self.
> >
> > 
> >
> > Fortunately, it's only included from private headers, so regular
> > applications  will not see it.
> 
> * It's qplatformdefs.h, not qplatformdefs_p.h
> * The include directory for it is part of QT += core, not core-private
> 
> If we want qplatformdefs to be a private header, then we'd have to change
> both  of those.
> 
> I know that's not exactly what you said, but actually I think it's a good 
> idea.
> 
> It is used in kdelibs in a few places.

It's not a private header, though in hindsight, it should have been. Like you 
said, now it's used in many places outside of Qt, so it's too late to change.

I was simply saying that the absence of the right -I will not be felt by most 
applications.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120916/d46b08db/attachment.sig>