[Development] Git commit hook keywords

[Thiago Macieira]

On domingo, 16 de setembro de 2012 10.34.32, Laszlo Papp wrote:
> > In any case, this is why we have reviewers: so they can teach newcomers
> > what
> > the policies are and how we do things. There will never be documentation
> > for
> > every single little thing, there's a lot that is latent knowledge.
> 
> Why would they teach if the newcomers knew after reading the documentation?
> The point of documentation is to share the knowledge (i.e. like this one),
> isn't it? If nobody does, I will do this later then.

I didn't say we don't need documentation. I said there will always be more 
information than what's documented and reviewers are supposed to teach.

> > As I said, it's the "Task-number" that triggers the completion in the
> > Gerrit
> > UI.
> 
> How will the "Task-number" entry know whether to jump to Gerrit or Jira? We
> need a distinction here because they are separate sources for information.

Simple: it always jumps to JIRA, never to Gerrit. Task are always in JIRA.

> > But that doesn't explain what QTREVIEW is, why it's misspelt and and why
> > we
> > don't need the same for other classes.
> 
> It is not misspelt. I intentionally wrote QT_REVIEW_ according to the
> QT_BUG_ schema. Like I wrote, it could be a better like QTCODEREVIEW or so.
> I was just presenting the idea.

Well, you could have said that. It's bad name because QTreeView exists and I 
guess lots of people will misread it, like I did. I hadn't realised it was "Qt 
Review" until now.

Anyway, the change number, the Change-Id or the SHA-1 of the commit are the 
keys you're looking for. I prefer the permalink or the commit SHA-1.

> > Paste the permalink of the Gerrit review or the Change-Id, or the bug ID
> > with
> > "Task-number: " prepended, or a link to the mailing list archives. It
> > doesn't
> > need to be a link anyway, just an identifier we can look up.
> 
> Except that, it would be nice to have the entry clickable which redirects
> instantly to the gerrit change without any further investigation. Like I
> said, just like how it happens in case the QTBUG entry.

It doesn't happen because of "QTBUG", it happens because of "Task-number:"

If you have a concrete suggestion for Gerrit keyword extracting, please make 
it. So far, this discussion has led nowhere and I still don't know what you 
want and what you've discovered so far.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120916/c31334f8/attachment.sig>