[Development] failing network tests on CI

[Stephen Kelly]

On Thursday, August 08, 2013 08:24:33 Thiago Macieira wrote:
> On quinta-feira, 8 de agosto de 2013 16:15:25, Stephen Kelly wrote:
> > Please fix the problem soon by doing whatever it takes to fix it quickly,
> > not  "properly".
> > 
> > There has been months and months of time to fix the problem, during which
> > time  the problem has not been fixed. I don't even know how long this has
> > been a problem, but it's at least 8 months.
> > 
> > Any time I've tried to fix the problem by disabling the tests, others have
> > put  themselves in the way
> 
> Probably because we disagree on what constitutes a "fix".

Yes, I guess it depends on the level of abstraction at which you consider the 
problem.

> A "fix" implies correcting the error. The error lies with the test server
> and the network setup. Therefore, a fix implies changing something there.
> 
> Disabling the tests is not a fix. It's a workaround, one with side-effects.
> Since we will not stop making changes that affect networking code, disabling
> network-related tests means we'll be flying blind for a while.

Not really. Insignificant tests are still executed. They'll still pass as 
often as they do now (assuming no true regressions), and that result will be 
recorded in the QtMetrics site.

> If we disable the tests, to be reasonably sure of not introducing
> regressions, we should also stop all changes to QtNetwork, event loops
> (QtCore and QPA plugins) and QObject kernel.

That's not necessary. The QtMetrics site can be checked regularly or before 
release if needed.

Thanks,

-- 
Join us in October at Qt Developer Days 2013 - https://devdays.kdab.com

Stephen Kelly <stephen.kelly at kdab.com> | Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130808/366726a5/attachment.sig>