[Development] Review process: when should I merge to staging?

Josh Faust jfaust at suitabletech.com
Mon Aug 12 20:58:19 CEST 2013


The Gerrit page says:
"By default, changes required +2 for Code Review and +1 for Sanity Review
categories to be approved"

That's what is required by the review system, but what is desired? If I've
added multiple people to the review (or others have added themselves),
should I wait for all (or most) of them to approve?

Specifically: https://codereview.qt-project.org/#change,62093

Josh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130812/4c2f589e/attachment.html>


More information about the Development mailing list