[Development] Review process: when should I merge to staging?

Laszlo Papp lpapp at kde.org
Mon Aug 12 21:03:53 CEST 2013


No, go ahead.


On Mon, Aug 12, 2013 at 7:58 PM, Josh Faust <jfaust at suitabletech.com> wrote:

> The Gerrit page says:
> "By default, changes required +2 for Code Review and +1 for Sanity Review
> categories to be approved"
>
> That's what is required by the review system, but what is desired? If I've
> added multiple people to the review (or others have added themselves),
> should I wait for all (or most) of them to approve?
>
> Specifically: https://codereview.qt-project.org/#change,62093
>
> Josh
>
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130812/a3e8572b/attachment.html>


More information about the Development mailing list