[Development] Review process: when should I merge to staging?

Josh Faust jfaust at suitabletech.com
Mon Aug 12 22:57:51 CEST 2013

> When you click review, there is a "Sanity Review" set of option
> buttons underneath the "Code Review" set. However it is folded up by
> default, you need to unfold it to see the options. Being slightly
> hidden like this is why it's relatively common for reviewers to forget
> to +1 the sanity when they meant to along with a +2.

Hmm. I don't see that on any of my own reviews, nor one that I just added
myself as a reviewer on. The only headings I see are "Code Review" and
"Cover Message", with "Code Review" being the only one that is collapsible.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130812/03f4e6ad/attachment.html>

More information about the Development mailing list