[Development] Review process: when should I merge to staging?

[Alan Alpert]

On Mon, Aug 12, 2013 at 1:57 PM, Josh Faust <jfaust at suitabletech.com> wrote:
>
>> When you click review, there is a "Sanity Review" set of option
>> buttons underneath the "Code Review" set. However it is folded up by
>> default, you need to unfold it to see the options. Being slightly
>> hidden like this is why it's relatively common for reviewers to forget
>> to +1 the sanity when they meant to along with a +2.
>
>
> Hmm. I don't see that on any of my own reviews, nor one that I just added
> myself as a reviewer on. The only headings I see are "Code Review" and
> "Cover Message", with "Code Review" being the only one that is collapsible.

It appears that I was mistaken, and only approvers can +1 sanity
review... New thread coming up, but that means that in the current
process if the sanity review is not ticked then you'll have to ping
the approver who +2'd it before you stage.

--
Alan Alpert