[Development] Proposal: Allow contributors to +1 sanity review.

Thiago Macieira thiago.macieira at intel.com
Mon Aug 12 23:55:38 CEST 2013

On segunda-feira, 12 de agosto de 2013 14:32:34, Alan Alpert wrote:
> If sanity permissions are not granted to contributors, then I'd like
> to fix the web form so the sanity review isn't hidden, to decrease the
> chance of it getting skipped by accident. It has happened to others as
> well as I, although it might just be the section of code I'm in has
> more false positives (qtdeclarative gets false positives fairly
> commonly from A) "Missing license header" because QML files in
> autotests do not have headers. B) "Adding large file" because our
> tests/examples have a lot of images). Every time I have to un-collapse
> that section I feel like someone hates me, but I know the bot/UI was
> just programmed like that and doesn't bear real malice  .

It was folded by default because people kept doing sanity reviews instead of 
code reviews, by accident.

Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130812/0d5c75a9/attachment.sig>

More information about the Development mailing list