[Development] Proposal: Allow contributors to +1 sanity review.

Alan Alpert 416365416c at gmail.com
Tue Aug 13 00:15:13 CEST 2013

On Mon, Aug 12, 2013 at 2:55 PM, Thiago Macieira
<thiago.macieira at intel.com> wrote:
> On segunda-feira, 12 de agosto de 2013 14:32:34, Alan Alpert wrote:
>> If sanity permissions are not granted to contributors, then I'd like
>> to fix the web form so the sanity review isn't hidden, to decrease the
>> chance of it getting skipped by accident. It has happened to others as
>> well as I, although it might just be the section of code I'm in has
>> more false positives (qtdeclarative gets false positives fairly
>> commonly from A) "Missing license header" because QML files in
>> autotests do not have headers. B) "Adding large file" because our
>> tests/examples have a lot of images). Every time I have to un-collapse
>> that section I feel like someone hates me, but I know the bot/UI was
>> just programmed like that and doesn't bear real malice  .
> It was folded by default because people kept doing sanity reviews instead of
> code reviews, by accident.

Then this is a really accident prone feature... but I'll withdraw my
request to remove the folding. We should investigate other options

Alan Alpert

More information about the Development mailing list