[Development] Proposal: Allow contributors to +1 sanity review.

Oswald Buddenhagen oswald.buddenhagen at digia.com
Wed Aug 14 13:29:58 CEST 2013

On Tue, Aug 13, 2013 at 11:04:14PM +0200, André Pönitz wrote:
> On Tue, Aug 13, 2013 at 10:45:21AM -0700, Thiago Macieira wrote:
> > I have overridden the bot sometimes when it complained that I used British 
> > English in the commit message. I know I shouldn't do that.
> To be honest, that's pretty much the only case where I find myself
> regularly disagreeing with the bots myself.
> It's certainly valuable to enforce "one style" when it comes to
> APIs (would be "fun" to have, say "QColor" and "setColour" at the
> same time...), but for "free text" as in commit messages that never
> gets touched again I am tempted to value cultural diversity higher
> than technical streamlining ;-}
well, there is a marginally convincing argument for streamlining that as
well: searchability (in particular with a primitive tool like 'less').

it may also look a bit weird if you have setColor and colour in the same
sentence. ;)

i have no particularly strong opinion on that, and it wouldn't be
terribly hard to exclude the commit messages from the check
(contributions welcome ;), but i find the "cultural diversity" argument
fairly stupid ... permitting british while true diversity in form of
other languages is excluded (for obvious reasons) feels ... fake.

More information about the Development mailing list