[Development] Some QIcon::fromTheme() enhancements

Thiago Macieira thiago.macieira at intel.com
Fri Aug 23 18:01:48 CEST 2013

On sexta-feira, 23 de agosto de 2013 18:48:40, Antti Kaijanmäki wrote:
> Should I just branch dev, cherrypick the commits from my old branch and 
> push to HEAD:refs/for/dev with the Change-Id's kept intact? Will this 
> preserve the existing review history?

Yes. No.

Unfortunately, when you push to another branch, it's a new review, even if you 
keep the Change-Ids intact. You will have to abandon the previous patch to 
stable. But since you're keeping the change-id, whenever someone goes looking 
for the change in the future, they'll see both submissions.

Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130823/4e7ef257/attachment.sig>

More information about the Development mailing list