[Development] Header diff for QtCore

Thiago Macieira thiago.macieira at intel.com
Mon Jul 8 23:55:53 CEST 2013


On sábado, 6 de julho de 2013 23.15.12, Thiago Macieira wrote:
> On sábado, 6 de julho de 2013 23.02.28, Thiago Macieira wrote:
> > On quarta-feira, 26 de junho de 2013 13.49.36, Thiago Macieira wrote:
> > > +    bool open(OpenMode mode = ReadWrite) Q_DECL_OVERRIDE;
> > 
> > This has just been confirmed as to cause a binary compatibility issue.
> > 
> > The rule for overriding virtuals is that it's ok, provided the old
> > implementation (namely, QIODevice::open) is still called. That's exactly
> > what happens if you compile Qt Creator with Qt 5.0 and run it with 5.1.
> > Utils::QtcProcess's vtable contains QIODevice::open, so it's like it
> > overrode and used the old implementation.
> 
> For the interested, the full details are on QTBUG-32284.

Fix is https://codereview.qt-project.org/60643

Speedy review is appreciated. This is affecting packages that are out there 
already.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20130708/d22e9b05/attachment.sig>


More information about the Development mailing list