[Development] Header diff for QtQml
Alan Alpert
416365416c at gmail.com
Thu Jun 27 02:23:56 CEST 2013
On Wed, Jun 26, 2013 at 2:51 PM, Thiago Macieira
<thiago.macieira at intel.com> wrote:
> One minor oops found:
>
> On quarta-feira, 26 de junho de 2013 13.50.06, Thiago Macieira wrote:
>> +++ b/src/qml/qml/qqmlextensionplugin.h
>> -private:
>> Q_DISABLE_COPY(QQmlExtensionPlugin)
>
> By removing the private:, with C++98 the error from trying to copy a
> Q_DISABLE_COPY moves from compile time to link time (undefined reference to
> QQmlExtensionPlugin's copy constructor or assignment operator).
>
> Bring it back.
https://codereview.qt-project.org/#change,59944 .
Also qqml.h now includes qdebug.h. While not harmful, do we have a
convention of not including that in public headers?
--
Alan Alpert
More information about the Development
mailing list