[Development] Names of classes in Android Extras
Stromme Christian
Christian.Stromme at digia.com
Tue Oct 8 02:02:45 CEST 2013
The names are one part legacy and one part for consistency. Either way I don't feel strongly about the names, so
if we can agree on the names I'll fix it asap.
So the options are QAndroidJniXxx and QJniXxx? Personally I prefer the later.
--
Christian
Thiago Macieira <thiago.macieira at intel.com> wrote:
On segunda-feira, 7 de outubro de 2013 22:11:28, Alejandro Exojo wrote:
> Hi.
>
> I've stumbled upon the names of the classes in Qt Android Extras:
> - QJNIEnvironment
> - QJNIObject
>
> The all capital part due to the acronym is inconsistent with other Qt
> classes, where the acronym is written as if it were a word: e.g. QHttp*
> instead of QHTTP*, QUrl instead of QURL, etc.
>
> I've mentioned on IRC, and Rich Moore told me it wasn't too late to mention
> the issue. He said it might be possible that the naming was chosen to be
> consistent with JNIEnv.
>
> What do you think?
Unless there's a compelling reason otherwise, I'd suggest renaming to QJniXxx.
Also, shouldn't there be an "Android" somewhere there?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
More information about the Development
mailing list