[Development] Split submission

[Ziller Eike]

Hi,

you can just have the patches sequentially in your local branch and push these together ("git push gerrit HEAD:refs/for/dev" or whereever that should go, that pushes all your local commits up to HEAD). Gerrit shows dependency information in the changes if you push them together, i.e. the 'later' changes show the changes they depend on in the dependencies section of the page. Gerrit never prevents that changes are (tried to be) submitted in a different order though, even with topic branches afaik. If you want to make sure that your reviewers are not confused (if you haven't talked to them already anyhow), you can add a comment about the dependency too.

Br, Eike

--
Eike Ziller
Senior Software Engineer

Digia Germany GmbH
Rudower Chaussee 13, D-12489 Berlin
Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B,
Geschäftsführer: Mika Pälsi, Juha Varelius, Anja Wasenius

________________________________________
From: development-bounces+eike.ziller=digia.com at qt-project.org [development-bounces+eike.ziller=digia.com at qt-project.org] on behalf of Samuel Gaist [samuel.gaist at edeltech.ch]
Sent: 10 October 2013 01:36
To: <development at qt-project.org>
Subject: [Development] Split submission

Hi,

I just started to split a submission in several patches like Stephen Kelly taught me.

There's just one thing I forgot to ask him: how should the patches be organized and sent since when broken down (it should be three patches), the last one would only apply once the second patch is applied ?

The first and second part can be separated (so two different submissions) since they solve two different but related problems (the second being triggered when solving the first).

Also what would be the best/recommended setup git wise ? Should I make a topic branch from my topic branch ?

Thank you
_______________________________________________
Development mailing list
Development at qt-project.org
http://lists.qt-project.org/mailman/listinfo/development