[Development] [Win32 API] Windows 8.1 deprectaed GetVersion(Ex) -> QSysInfo should be fixed!

[MuldeR]

Hello.

I currently have no time for the gerrit setup process, but here is a patch against Qt 4.8.5, for everyone interested in fixing QSysInfo on Windows:
http://pastie.org/private/arnuqyvur4org7ivmwu14a

Only file modified is "qglobal.cpp".

As for copyright concerns, I have written all the additional code from the scratch (with some inspiration from the MSDN examples) and hereby grand everyone to use that code under the Qt license.

But that code basically is a simple wrapper around the VerifyVersionInfo() API, so I don't think there's much intellectual property in it ;-)

Regards,
MuldeR


On 20.10.2013 17:32, Giuseppe D'Angelo wrote:
> On 20 October 2013 15:56, MuldeR <mulder2 at gmx.de> wrote:
>>
>> Code is here:
>> http://pastie.org/private/kkva8pkk7nzcmm8jjwstfa
>>
>> Tested on: Windows XP (RTM), Windows 7 SP-1, Windows 8.0, Windows 8.1
>>
>> (should work on Windows 2000 too, but I don't really care)
>
> Thanks, but the Qt Project can't accept a submission this way (unless
> it's "trivial" and thus not copyrightable, but that's of course grey
> territory. I didn't click on the link.)
>
>  Can you please create a proper patch request on gerrit? We have handy
> guides for the whole process (it's has 3-4 setup steps you need to do
> the first time, but from then on it's trivial).
>
> http://qt-project.org/wiki/Code_Reviews
> http://qt-project.org/wiki/Setting-up-Gerrit
> http://qt-project.org/wiki/Gerrit-Introduction
>
> Thank you,


-- 
http://www.youtube.com/watch_popup?v=Jay-fG9eaYk#!