[Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST
mitch.curtis at digia.com
Wed Jun 18 16:29:57 CEST 2014
On 06/18/2014 01:35 PM, Haataja Ismo wrote:
>> From: Curtis Mitch
>> Do you know if searching by SHA-1 will ever work? Searching by change ID
>> is good, but you don't always have one available.
> If gerrit just has a patch set 'linked' with that SHA1, it works. And has been working, I think.
> But our previous gerrit version didn't had the SHA1 of merged patch set. Or not elsewhere but in the change message saying: "Change has been successfully cherry-picked to the staging branch as 2bbccf8ca1a4ba7e39413982986bc02d55e936be." Search doesn't find it from there. You may have already seen that the new gerrit version we deployed, doesn't show SHA1 when staging, just "Change has been successfully cherry-picked to the staging branch ." But, when a change gets merged, a new patch set is created. With the SHA1 that should match the actual commit. Now search should work using this SHA1.
> So, for new changes, starting from Jun-13, search should work just fine.
> A little test to convince myself :)
> [ismo at masiina qtbase.git]$ git log 5.3.1 --oneline -n5
> cf7805d Merge "Merge remote-tracking branch 'origin/stable' into 5.3" into refs/staging/5.3
> bdd6046 Fix animations in static builds
> 753be5a Merge remote-tracking branch 'origin/stable' into 5.3
> c92ece4 QRasterPlatformPixmap::createPixmapForImage(): Avoid crash when QImage conversion failes
> 4038f21 xcb: touch device mode is either Dependent or Direct, not Rel or Abs
> Copy pasted four SHA1 values to search field and all but first one worked ok. And the first one is not done by gerrit, I think, so that's ok too.
Thanks, that does work.
More information about the Development