[Development] Expiring old change reviews

Thiago Macieira thiago.macieira at intel.com
Fri Jun 27 18:41:13 CEST 2014


Em sex 27 jun 2014, às 10:22:38, Frederik Gladhorn escreveu:
> Torsdag 26. juni 2014 18.14.49 skrev Thiago Macieira:
> > I've just counted: I have 203 pending reviews for me. At least half of
> > them
> > haven't been updated in six months. Some of them are for the old master
> > and
> > api_changes branches and will never, ever be accepted unless resubmitted.
> > 
> > Last we discussed this, we were waiting for Gerrit to be updated. It has
> > now.
> > 
> > Can we please expire old stuff?
> 
> Ossi is working on it, so it's going to happen soon.

Thanks!

I also noticed quite a few reviews that were completely approved and ready to 
be submitted, but never were because the owner didn't realise they had to 
press the button. I did press the button for those people where I could.

There are also several completely approved and whose owner are active Qt 
Project members. I haven't touched those, assuming that there's a reason why 
they haven't been updated in a year or so.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list