[Development] qt-4.8.x gcc5 version/detection issues

[Frederik Gladhorn]

On Monday, February 16, 2015 08:55:14 AM Rex Dieter wrote:
> Found a couple more gcc5-related issues with qt-4.8.x builds:
> 
> * webkit components don't build, this is due to a configure check for
> gcc-4.x, here's my quick-n-dirty fix (for g++ stanza only, others probably
> should get touched too):
> 
> http://pkgs.fedoraproject.org/cgit/qt.git/tree/qt-fix_detection_of_gcc5.patc
> h
> 
> 
> * QT_BUILD_KEY handling
> 
> Similar to webkit above, the configure bits about QT_BUILD_KEY only handles
> up to gcc-4.x.
> 
> For fedora 22, our gcc5 builds are done in a way that is (supposedly) ABI
> compatible to gcc4, so I'm currently using:
> http://pkgs.fedoraproject.org/cgit/qt.git/tree/qt-gcc5_compat_qt_build_key.p
> atch to ensure QT_BUILD_KEY matches (ie, it includes the same g++-4 string
> as before).
> 
> As far as upstream is concerned, I assume you'd prefer the default here to
> be g++-5 ?
> 
> 
> Both of these are fairly simple/obvious, is this sufficient or would you
> rather I post something to codereview?

Since you did the patch already the fastest and most convenient for all 
involved would be if you pushed it to codereview. Just add a few people to 
review and it'll be in quickly.

Thanks,
Frederik

> 
> 
> -- Rex
> 
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development