[Development] QTextStream::readLine(0) is an ambiguous overload in 5.5

[Smith Martin]

I think output parameters are supposed to be placed at the end; their names should indicate that they are outputs, and the documentation should say they are changed by the function.

martin

________________________________________
From: Giuseppe D'Angelo <dangelog at gmail.com>
Sent: Sunday, May 17, 2015 9:57 PM
To: Smith Martin
Cc: Marc Mutz; development at qt-project.org
Subject: Re: [Development] QTextStream::readLine(0) is an ambiguous overload in 5.5

On Sun, May 17, 2015 at 9:55 PM, Smith Martin
<Martin.Smith at theqtcompany.com> wrote:
> How do you get bitten by an out-reference?

As usual, because at call site I didn't realize the argument was
actually being modified. Compare

doSomething(param1, param2, param3);
doSomething(&param1, param2, param3);

which one is likely to be modifying arguments?

--
Giuseppe D'Angelo