[Development] commas in ctor-init-lists

Dominik Holland dominik.holland at pelagicore.com
Wed Jun 1 14:57:27 CEST 2016


+1 for changing they coding style

Am 06/01/2016 um 02:56 PM schrieb Simon Hausmann:
> Hi,
> 
> I'm in favorof changing our coding style to adopt the model you call
> "butt ugly" because I find it more appealing and I find that it makes
> diffs easier to read.
> 
> Simon 
> 
> 
> ------------------------------------------------------------------------
> *From:* Marc Mutz <marc.mutz at kdab.com>
> *Sent:* Jun 1, 2016 14:41
> *To:* development at qt-project.org
> *Subject:* [Development] commas in ctor-init-lists
> 
> Hi,
> 
> There seems to have been a silent underground move to uglify the Qt sources
> , by using commas to introduce lines
> . I have no idea where this came from
> , but it looks butt
> -ugly and it is in violation of http
> ://wiki
> .qt
> .io
> /Qt_Coding_Style
> 
> QFoo::QFoo()
>   : QBase(),
>     m_f1(),
>     m_f2()
> {
> 
> }
> 
> -not-
> 
> QFoo::QFoo()
>   : QBase()
>   , m_f1()
>   , m_f2()
> {
> 
> }
> 
> (http://wiki.qt.io/Qt_Coding_Style#Line_breaks 2nd item: "Commas go at the
> _end_ of wrapped lines")
> 
> Thanks,
> Marc
> 
> -- 
> Marc Mutz <marc.mutz at kdab.com> | Senior Software Engineer
> KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
> Tel: +49-30-521325470
> KDAB - Qt, C++ and OpenGL Experts
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
> 
> 
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
> 

-- 
Dominik Holland
SENIOR SOFTWARE ENGINEER

Pelagicore AG
Balanstr. 55, 81541 Munich, Germany
+49 (0)171 760 25 96
dominik.holland at pelagicore.com
www.pelagicore.com




More information about the Development mailing list