[Development] Dropping qtserialbus from Qt 5.6 -- it doesn't compile in C++98

[Heikkinen Jani]

Hi,

QtSerialBus is a technology preview in 5.6 and so on this shouldn't matter that much, right? This "limitation" should be acceptable for TPs and so on adding this in known issues page (https://wiki.qt.io/Qt_5.6.0_Known_Issues) should be enough?

Br,
Jani

>>-----Original Message-----
>>From: Development [mailto:development-
>>bounces+jani.heikkinen=theqtcompany.com at qt-project.org] On Behalf Of
>>Thiago Macieira
>>Sent: 3. maaliskuuta 2016 8:59
>>To: development at qt-project.org
>>Subject: [Development] Dropping qtserialbus from Qt 5.6 -- it doesn't compile in
>>C++98
>>
>>The code was written for C++11 only and there isn't enough time to fix the
>>build issues. Therefore, it needs Qt 5.7.
>>
>>I request that it be dropped from Qt 5.6 packages.
>>
>>See:
>>
>>https://codereview.qt-project.org/151163
>>https://codereview.qt-project.org/151168
>>
>>Unfixed errors:
>>qmodbuspdu.h:163:9: warning: identifier ‘static_assert’ is a keyword in C++11
>>[-Wc++0x-compat]
>>
>>qmodbusdataunit.h:57:25: warning: defaulted and deleted functions only
>>available with -std=c++11 or -std=gnu++11
>>
>>qmodbusdataunit.h:46:7: error: constructor required before non-static data
>>member for ‘QModbusDataUnit::m_type’ has been parsed
>>
>>qmodbusdataunit.h:60:37: warning: delegating constructors only available with
>>-std=c++11 or -std=gnu++11
>>	=>	delegating constructors are not permitted even with Qt 5.7
>>
>>qmodbuspdu.h:87:20: warning: defaulted and deleted functions only available
>>with -std=c++11 or -std=gnu++11
>>
>>qmodbuspdu.h:119:24: warning: variadic templates only available with -std=c+
>>+11 or -std=gnu++11
>>
>>qmodbuspdu.h:159:24: error: ‘is_same’ is not a member of ‘std’
>>qmodbuspdu.h:168:23: error: ‘is_pod’ is not a member of ‘std’
>>	=> need to check if those allowed in Qt 5.7
>>
>>After this, the parser gets lost.
>>
>>--
>>Thiago Macieira - thiago.macieira (AT) intel.com
>>  Software Architect - Intel Open Source Technology Center
>>
>>_______________________________________________
>>Development mailing list
>>Development at qt-project.org
>>http://lists.qt-project.org/mailman/listinfo/development