[Development] Dropping qtserialbus from Qt 5.6 -- it doesn't compile in C++98

Thiago Macieira thiago.macieira at intel.com
Thu Mar 3 07:59:15 CET 2016


The code was written for C++11 only and there isn't enough time to fix the 
build issues. Therefore, it needs Qt 5.7.

I request that it be dropped from Qt 5.6 packages.

See:

https://codereview.qt-project.org/151163
https://codereview.qt-project.org/151168

Unfixed errors:
qmodbuspdu.h:163:9: warning: identifier ‘static_assert’ is a keyword in C++11 
[-Wc++0x-compat]

qmodbusdataunit.h:57:25: warning: defaulted and deleted functions only 
available with -std=c++11 or -std=gnu++11

qmodbusdataunit.h:46:7: error: constructor required before non-static data 
member for ‘QModbusDataUnit::m_type’ has been parsed

qmodbusdataunit.h:60:37: warning: delegating constructors only available with 
-std=c++11 or -std=gnu++11
	=>	delegating constructors are not permitted even with Qt 5.7

qmodbuspdu.h:87:20: warning: defaulted and deleted functions only available 
with -std=c++11 or -std=gnu++11

qmodbuspdu.h:119:24: warning: variadic templates only available with -std=c+
+11 or -std=gnu++11

qmodbuspdu.h:159:24: error: ‘is_same’ is not a member of ‘std’
qmodbuspdu.h:168:23: error: ‘is_pod’ is not a member of ‘std’
	=> need to check if those allowed in Qt 5.7

After this, the parser gets lost.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list