[Development] Are we free of code that checks this isn't null?

Marc Mutz marc.mutz at kdab.com
Sat Mar 5 02:17:59 CET 2016


On Saturday 05 March 2016 00:21:38 Thiago Macieira wrote:
> On sexta-feira, 4 de março de 2016 23:27:49 PST Marc Mutz wrote:
> > Do you also have a fix for this one:
> >   ../../include/QtCore/../../../../qt5/qtbase/src/corelib/kernel/qobjectd
> >   efs
> > 
> > .h:175:108: error:  ‘visibility’ attribute ignored [-Werror=attributes]
> > 
> >        Q_DECL_HIDDEN_STATIC_METACALL static void
> >        qt_static_metacall(QObject
> > 
> > *,  QMetaObject::Call, int, void **); \
> 
> Yes, but I can't find it. I might have dropped it because it wasn't
> working, due to a GCC bug. The bug has since been fixed.
> 
> We need to make Q_DECL_HIDDEN_STATIC_METACALL include the pragma disabling
> that particular warning.
> 
> This is a blind, untested change:
> https://codereview.qt-project.org/151467

Didn't work for me, but gave me the right idea. Fixed now. Updated.

Thanks,
Marc

-- 
Marc Mutz <marc.mutz at kdab.com> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - The Qt Experts



More information about the Development mailing list