[Development] Are we free of code that checks this isn't null?

Thiago Macieira thiago.macieira at intel.com
Sat Mar 5 00:21:38 CET 2016


On sexta-feira, 4 de março de 2016 23:27:49 PST Marc Mutz wrote:
> Do you also have a fix for this one:
> 
>   ../../include/QtCore/../../../../qt5/qtbase/src/corelib/kernel/qobjectdefs
> .h:175:108: error:  ‘visibility’ attribute ignored [-Werror=attributes]
>        Q_DECL_HIDDEN_STATIC_METACALL static void qt_static_metacall(QObject
> *,  QMetaObject::Call, int, void **); \

Yes, but I can't find it. I might have dropped it because it wasn't working, 
due to a GCC bug. The bug has since been fixed.

We need to make Q_DECL_HIDDEN_STATIC_METACALL include the pragma disabling 
that particular warning.

This is a blind, untested change:
https://codereview.qt-project.org/151467

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list