[Development] Qt 5.6.0 (final) packages available

Thiago Macieira thiago.macieira at intel.com
Tue Mar 15 06:28:07 CET 2016

On terça-feira, 15 de março de 2016 00:26:06 PDT Marc Mutz wrote:
> > Not acceptable. I will only apply the patch if I understand what it does
> > and what the consequences are. I can only do that in April.
> I'd say it's the job of the patch *author* to describe all this in the
> commit message, not the job of the reviewer to go dig out the missing
> information by himself.

True, but as a good reviewer and especially as the maintainer, I want to 
understand what the thing does. If I'm not comfortable with the change, I'm 
not supposed to approve it. If I'm the maintainer, I'd be stuck with that 

In this specific case, it's brand, new code that I wrote recently, so I'm 
supposed to know it well. And the way I designed it, deadlocks were not 
supposed to happen. So I need to investigate why they're happening in the first 

No offence to the patch author, but I have more experience with this.

Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

More information about the Development mailing list