[Development] Speeding up the review process (was: PostgreSQL cross compile for Pi)

Kai Koehne Kai.Koehne at qt.io
Tue Oct 17 15:09:54 CEST 2017

> -----Original Message-----
> From: Development [mailto:development-bounces+kai.koehne=qt.io at qt-
> project.org] On Behalf Of Martin Smith
> [...]
> I am a member of the Qt documentation team, and I am often included as a
> reviewer for code changes that also include changes to qdoc comments. I
> always assume I am meant to review only the documentation, so if the
> documentation is ok, I give the change a +1 and add a comment that I only
> reviewed the documentation.
> Is this the right way to do it? Maybe it should be formalized in the system.

Yes, I think this is the right way. 

Writing the comment is the key here. We just have -2, -1, +1, +2 available, so a '+1' can mean everything from 'I had barely a look' to 'I just checked parts of it' to 'I think the patch is flawless, but just maybe someone else wants to review it, too' .

So, given the limited options, let's just state explicitly what you mean when giving a review. While at it, consider also to mention positive things, so people don't feel like they only ever get negative feedback.

My 2 cents,


More information about the Development mailing list