[Development] Speeding up the review process (was: PostgreSQL cross compile for Pi)

Konstantin Tokarev annulen at yandex.ru
Tue Oct 17 15:25:48 CEST 2017

17.10.2017, 16:10, "Kai Koehne" <kai.koehne at qt.io>:
>>  -----Original Message-----
>>  From: Development [mailto:development-bounces+kai.koehne=qt.io at qt-
>>  project.org] On Behalf Of Martin Smith
>>  [...]
>>  I am a member of the Qt documentation team, and I am often included as a
>>  reviewer for code changes that also include changes to qdoc comments. I
>>  always assume I am meant to review only the documentation, so if the
>>  documentation is ok, I give the change a +1 and add a comment that I only
>>  reviewed the documentation.
>>  Is this the right way to do it? Maybe it should be formalized in the system.
> Yes, I think this is the right way.
> Writing the comment is the key here. We just have -2, -1, +1, +2 available, so a '+1' can mean everything from 'I had barely a look' to 'I just checked parts of it' to 'I think the patch is flawless, but just maybe someone else wants to review it, too' .

It's possible to configure more labels to vote for beyound Code-Review and Sanity-Review, see


> So, given the limited options, let's just state explicitly what you mean when giving a review. While at it, consider also to mention positive things, so people don't feel like they only ever get negative feedback.
> My 2 cents,
> Kai
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development


More information about the Development mailing list