[Development] Speeding up the review process (was: PostgreSQL cross compile for Pi)

Thiago Macieira thiago.macieira at intel.com
Tue Oct 17 16:36:31 CEST 2017


On terça-feira, 17 de outubro de 2017 06:25:48 PDT Konstantin Tokarev wrote:
> > Writing the comment is the key here. We just have -2, -1, +1, +2
> > available, so a '+1' can mean everything from 'I had barely a look' to 'I
> > just checked parts of it' to 'I think the patch is flawless, but just
> > maybe someone else wants to review it, too' .
> It's possible to configure more labels to vote for beyound Code-Review and
> Sanity-Review, see
> 
> https://codereview.qt-project.org/Documentation/config-labels.html

It is, but it gets a lot more confusing quickly, so I question the benefit of 
adding more labels. There's a reason the Sanity Review is hidden by default...

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center




More information about the Development mailing list