[Development] Fwd: qrandom.cpp build problem: please advise

[Alexei Fedotov]

Hi Edward,
thanks for a quick solution!

The patch worked for me (with  -recheck-all). I defensively used long
<sys/random.h> include instead of a short "random.h".
--
Carry a towel
http://dataved.ru/
+7 916 562 8095

[1] Join Alexei Fedotov @linkedin, http://ru.linkedin.com/in/dataved/
[2] Join Alexei Fedotov @facebook, http://www.facebook.com/openmeetings
[3] Start using Apache Openmeetings today, http://openmeetings.apache.org/


On Tue, Feb 27, 2018 at 12:11 PM, Edward Welbourne
<edward.welbourne at qt.io> wrote:
> Alexei Fedotov (27 February 2018 09:45)
>> ./configure sets getentropy in qtbase/src/corelib/qtcore-config_p.h to 1,
>
> So the config.tests/unix/getentropy/ test passed.
>
>> but I have no sys/random.h
>
> which that test neglects to #include, so this lack doesn't keep it from failing.
> See if
> https://codereview.qt-project.org/221462
> helps.  (It's not ideal; it should make the test fail for you, though,
> so you'll have the feature turned off, despite being available, so
> you won't hit your compilation problem.)
>
>> Maybe getentropy comes from a modern compiler, not from system headers
>
> Apparently it comes from <unistd.h> - at least, that's
> what the test seems to expect and its man-page claims.
>
> The author of this code may suggest some better solution, once
> his USAish time-zone reaches its daytime,
>
>         Eddy.