mitch.curtis at qt.io
Fri Jan 5 15:27:03 CET 2018
Andy just pointed me towards this:
I guess making it public would work too, and might even be the better option if people are already using it (unofficially) anyway.
Either way, both need to be public or private.
From: Development [mailto:development-bounces+mitch.curtis=qt.io at qt-project.org] On Behalf Of Mitch Curtis
Sent: Friday, 5 January 2018 3:18 PM
To: Simon Hausmann <Simon.Hausmann at qt.io>; development at qt-project.org
Subject: Re: [Development] QQmlAbstractUrlInterceptor
I would be for that, considering there doesn't seem to have been a clear reason for making it public in either the commit message or docs.
From: Simon Hausmann
Sent: Friday, 5 January 2018 3:11 PM
To: Mitch Curtis <mitch.curtis at qt.io<mailto:mitch.curtis at qt.io>>; development at qt-project.org<mailto:development at qt-project.org>
Subject: Re: QQmlAbstractUrlInterceptor
I don't know either to be honest, this was a long time ago it seems. Perhaps we should consider marking the class \internal, as its "setter" on QQmlEngine is \internal, too.
The feature that is public and document and that uses QQmlAbstractUrlInterceptor under the hood is QQmlFileSelector.
From: Development <development-bounces+simon.hausmann=qt.io at qt-project.org<mailto:development-bounces+simon.hausmann=qt.io at qt-project.org>> on behalf of Mitch Curtis <mitch.curtis at qt.io<mailto:mitch.curtis at qt.io>>
Sent: Friday, January 5, 2018 3:06:58 PM
To: development at qt-project.org<mailto:development at qt-project.org>
Subject: [Development] QQmlAbstractUrlInterceptor
While looking into https://bugreports.qt.io/browse/QTBUG-65444, I noticed that QQmlAbstractUrlInterceptor is a public class with documentation that doesn't really explain how to use it. See my comment here:
Here's an old mailing list thread I found about it:
Why was a public class added that can seemingly only be used with private API? Why did it have to be made public? And why doesn't the documentation actually explain how to use it?
Development mailing list
Development at qt-project.org<mailto:Development at qt-project.org>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Development