[Development] Did we have to remove cmake's qt5_use_modules?

Thiago Macieira thiago.macieira at intel.com
Fri Jun 8 17:10:12 CEST 2018


On Friday, 8 June 2018 07:59:10 PDT Kevin Funk wrote:
> I would lean towards restoring qt5_use_modules() in Qt 5.11.1 (and keep it
> for the Qt5 lifetime). But I'd leave the other removals of
> 02ed1b36daebed5f3997bb676cf5e818c0db9d3c (mainly removal of support of older
> CMake versions) intact.
> 
> Agreed? If so I'll file a patch soon-ish.

I think it makes sense. This doesn't look like a simple change.

The missing #includes is a known issue and even then I looked at what caused 
the issue for QButtonGroup and QAction. I can't find the relevant change.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center






More information about the Development mailing list