[Development] Did we have to remove cmake's qt5_use_modules?

[Lisandro Damián Nicanor Pérez Meyer]

El viernes, 8 de junio de 2018 11:59:10 -03 Kevin Funk escribió:
[snip]
> Heya Thiago,
> 
> thanks for bringing this up on the mailing list. I have authored the patch
> which (also) removed qt5_use_modules(). To my excuse, I haven't expected
> that so many projects still use said macro actively. I was maybe misguided
> by my perception from the KDE world; where most projects have used to using
> target_link_libraries(...).
> 
> I understand that the removal of qt5_use_modules() creates tons of
> unnecessary extra work for distro and project maintainers.
> 
> I would lean towards restoring qt5_use_modules() in Qt 5.11.1 (and keep it
> for the Qt5 lifetime).

That would be much appreciated.

> But I'd leave the other removals of
> 02ed1b36daebed5f3997bb676cf5e818c0db9d3c (mainly removal of support of older
> CMake versions) intact.

I think this is safe, we normally do not expect building new Qt versions with 
older CMake versions in distros. I think.

Thanks a lot!!

-- 
If little green men land in your back yard, hide any little green women
you've got in the house.
  Mike Harding, "The Armchair Anarchist's Almanac"

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20180611/be272b08/attachment.sig>