[Development] Qt API review process (was: Re: Qt 5.11 Alpha released)

[Jani Heikkinen]

Hi all,

We have API review ongoing for Qt 5.11. For me our process for that is a bit unclear; At which point we can say the review is really done? There are comments in the reviews but then pretty much nothing... At some there is -1, few +1 but that's it. I think we should clarify the process so that we can more easily see the status there. That's why I propose following:

1) API review for the module is ready when there is '+2'  (from Module/Chief Maintainer)
2) During the review reviewer must add 'Code Review -1/-2' if there is something which should be corrected before we can agree API review to be ready. And vice versa: if API seems to be OK +1 should be added to indicate API is reviewed.
3) Reviewer needs to create a bug report about the findings. That makes it easier to follow up & we can add needed ones in the release blocker list.
   * These bug reports should be added in review's comment field as well. And if one is something which really needs to be fixed before release reviewer should add the issue in release blocker list.
4) API review for module needs to be updated in gerrit until it gets '+2'. After that no more updates. That way we can link the approved review in releasing wiki for the evidence :D

br,
Jani 
________________________________________
From: Edward Welbourne
Sent: Wednesday, February 21, 2018 6:43 PM
To: development at qt-project.org
Cc: releasing at qt-project.org; Jani Heikkinen
Subject: Re: Qt 5.11 Alpha released

Jani Heikkinen (20 February 2018 11:14)
> We have release Qt 5.11 Alpha today, see http://blog.qt.io/blog/2018/02/20/qt-5-11-alpha-released/

and so, of course, we also have 5.11 API reviews, vs v5.10.1:

https://codereview.qt-project.org/221039 qtbase
https://codereview.qt-project.org/221040 qtdeclarative
https://codereview.qt-project.org/221041 qtmultimedia
https://codereview.qt-project.org/221042 qttools
https://codereview.qt-project.org/221043 qtxmlpatterns
https://codereview.qt-project.org/221044 qtlocation
https://codereview.qt-project.org/221045 qtconnectivity
https://codereview.qt-project.org/221046 qtwayland
https://codereview.qt-project.org/221047 qt3d
https://codereview.qt-project.org/221048 qtserialbus
https://codereview.qt-project.org/221049 qtandroidextras
https://codereview.qt-project.org/221050 qtwebengine
https://codereview.qt-project.org/221051 qtcharts
https://codereview.qt-project.org/221052 qtgamepad
https://codereview.qt-project.org/221053 qtremoteobjects

See the review comments for guidance, consult actual source for
definitive views of code - note that these reviews are generated by a
script that filters out changes deemed boring; it has learned, on this
iteration, to not waste your time with s/Q_DECL_FINAL/final/ or
s/Q_QDOC/Q_CLANG_QDOC/ changes; and to ignore the addition of
Q_DECL_COLD_FUNCTION.  Speaking of which, please accept my apologies
for not delivering this two days ago - I got distracted by trying to
revamp the script to be a bit smarter about detecting boring changes
that add a line, among other things.

        Eddy.