[Development] 5.14 API change reviews

Albert Astals Cid albert.astals.cid at kdab.com
Mon Aug 26 19:10:37 CEST 2019

El dilluns, 26 d’agost de 2019, a les 18:14:01 CEST, Edward Welbourne va 
> Hi all,
> As some have clearly noticed unprompted, I've now posted the first
> drafts of the 5.14 API change reviews [0], in accordance with QUIP 10
> [1].  Please file bugs in Jira for any changes you object to and link
> those bugs to QTBUG-77839 [2], blocking it.  Please tag any changes you
> make to fix issues noticed in review, either with Fixes: for such a bug
> report or with a Task-number: QTBUG-77839 footer.

How hard would be for those diffs to include the documentation (in the .cpp 

This way it would be easier to catch that for example that the 
QWebSocketServer::setHandshakeTimeout function that according to 
is new in 5.14 does not include the \since marker


> As ever, remember that these reviews filter out lots of trivial changes,
> so check the actual 5.14 (and, where relevant, 5.13.1) sources if in
> doubt about what's really there.  The boring changes filtered out of
> qtbase totalled more than twice the residue presented for review.
> [0]
> https://codereview.qt-project.org/q/topic:%2522api-change%2522+status:open
> [1] https://quips-qt-io.herokuapp.com/quip-0010-API-review.html
> [2] https://bugreports.qt.io/browse/QTBUG-77839
> Feature freeze has happened, so please make no changes to 5.14's public
> APIs other than fixes in response to these reviews.
> If you know a module has had material changes requiring an update to the
> review, please either read the commit message (it says how to update it)
> or drop me a line,
> 	Eddy.
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> https://lists.qt-project.org/listinfo/development

Albert Astals Cid | albert.astals.cid at kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - The Qt, C++ and OpenGL Experts

More information about the Development mailing list