[Development] Proposal: New branch model

Shawn Rutledge Shawn.Rutledge at qt.io
Fri Jan 25 13:30:52 CET 2019



> On 25 Jan 2019, at 09:43, Martin Smith <Martin.Smith at qt.io> wrote:
> 
>> It is the absolute exception that a change goes into qtbase on first attempt.
> 
> But many rejections have nothing to do with any change at all. I often submit documentation-only changes to QtBase, and they often get tested alone, with no other changes. They still get rejected multiple times because test X fails this time and test Y fails next time, despite the fact that my change only fixes typos in the qdoc comments. Sometimes there is a compiler failure too, which is not caused by the change.

Could we simplify testing for some types of patches?  E.g. if the patch only touches documentation, don’t run tests, except those that involve building docs, if we have any of those.  (Even building the code is dubious in that case, as long as the bot that decides that it’s a doc-only patch actually verifies that the only changes are inside comments.)  If it only touches widgets, some time-consuming and failure-prone tests like network tests could be skipped.  And so on.



More information about the Development mailing list