[Development] GitHub Pull requests
Konstantin Tokarev
annulen at yandex.ru
Tue Mar 10 18:06:39 CET 2020
10.03.2020, 19:25, "Cristián Maureira-Fredes" <cristian.maureira-fredes at qt.io>:
> Hello,
>
> On 3/10/20 3:48 PM, Konstantin Tokarev wrote:
>> I think, lowering barrier of entry at expense of reviewers' convenience should
>> have its limits
>
> Totally agree,
> so we should plan to accept patches from platform and systems
> made for code development, like Github :)
>
> , otherwise we may end up accepting contributions from Twitter:)
>
> If Twitter becomes on a code development platform
> with pull-requests, reviews, and so on...sure :P
My point is that GitHub is inferior as a code review platform. Lowering entry barrier
for drive-by contributors (who quite likely won't come back to maintain code they've
introduced), it reduces quality of life for reviewers.
--
Regards,
Konstantin
More information about the Development
mailing list